Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Workflow #68

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

CI Workflow #68

wants to merge 10 commits into from

Conversation

hemant10yadav
Copy link
Contributor

@hemant10yadav hemant10yadav commented Jan 8, 2025 •
edited by jira bot
Loading

This PR introduces the following changes: CCCT-637

  • Adds django-environ to load environment variables.
  • Includes ci.yml configuration for running pytest in CI.
  • Adds linting configurations.

Additionally, follow the branches below to view formatting and pytest fixes:

  • Formatting changes: #69
  • Test fixes: #70

@hemant10yadav hemant10yadav changed the title configs CI-workflow Jan 8, 2025
@hemant10yadav hemant10yadav changed the title CI-workflow CI Workflow Jan 8, 2025
@hemant10yadav hemant10yadav mentioned this pull request Jan 8, 2025
Open
calellowitz
calellowitz requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few changes but this looks very close

connectid/settings.py Outdated Show resolved Hide resolved
connectid/settings.py Outdated Show resolved Hide resolved
connectid/settings.py Outdated Show resolved Hide resolved
connectid/settings.py Show resolved Hide resolved
calellowitz
calellowitz reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few changes still missing, but getting closer

.env_template Outdated Show resolved Hide resolved
calellowitz
calellowitz reviewed Jan 15, 2025
View reviewed changes
.env_template Outdated Show resolved Hide resolved
calellowitz
calellowitz reviewed Jan 15, 2025
View reviewed changes
connectid/settings.py Outdated Show resolved Hide resolved
pxwxnvermx
pxwxnvermx reviewed Jan 15, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@pxwxnvermx pxwxnvermx mentioned this pull request Jan 15, 2025
Closed
@sravfeyn
Copy link
Member

Apart from some minor comments, looks good. It will be nice to update any READMEs on local setup to copy using env_template instead of example localsettings.

@hemant10yadav
Copy link
Contributor Author

Apart from some minor comments, looks good. It will be nice to update any READMEs on local setup to copy using env_template instead of example localsettings.

I will update the README as well.

@calellowitz
Copy link
Collaborator

Looks like tests are still failing, but otherwise looks good.

@hemant10yadav
Copy link
Contributor Author

hemant10yadav commented Jan 23, 2025 •
edited
Loading

Looks like tests are still failing, but otherwise looks good.

@calellowitz I have fixed the test in #69 and #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxwxnvermx pxwxnvermx pxwxnvermx left review comments

@calellowitz calellowitz calellowitz requested changes

@sravfeyn sravfeyn sravfeyn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hemant10yadav @sravfeyn @calellowitz @pxwxnvermx