Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Es/tempus dominus #35629

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Es/tempus dominus #35629

wants to merge 7 commits into from

Conversation

esoergel
Copy link
Contributor

Product Description

Technical Summary

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Migrations

  • The migrations in this code can be safely applied first independently of the code

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@esoergel
Use test branch of tempus-dominus
3ca8acf
@esoergel
Use shared HTML for both types of datetime widgets
9e27db8
@esoergel
Target input-group instead of input field
d5994c5 
As per tempus-dominus's docs.  This lets us make the icon selectable.
This commit also adds a calendar icon for daterange fields
https://getdatepicker.com/6/repl.html
@esoergel
Also update datetime widget in form entry
a43c9fd
@esoergel
There is no Entry with templateType = 'datetime'
cd5fad1 
And of course datetime questions show up as unsupported in webapps
@esoergel
Use same HTML for both tempus dominus widgets
0d65f9e 
(And also for datetimes if we add those back in the future)
@esoergel
Make daterange picker close automatically
b1804e1 
When second date is selected.  This is still a little janky - if you
reopen, it's hard to select a new date range unless you clear first.
I think this would need to be addressed in the library
@dimagimon dimagimon added dependencies Pull requests that update a dependency file Risk: Medium Change affects files that have been flagged as medium risk. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangejenny orangejenny Awaiting requested review from orangejenny orangejenny will be requested when the pull request is marked ready for review orangejenny is a code owner

@biyeun biyeun Awaiting requested review from biyeun biyeun will be requested when the pull request is marked ready for review biyeun is a code owner

@MartinRiese MartinRiese Awaiting requested review from MartinRiese MartinRiese will be requested when the pull request is marked ready for review MartinRiese is a code owner

@AddisonDunn AddisonDunn Awaiting requested review from AddisonDunn AddisonDunn will be requested when the pull request is marked ready for review AddisonDunn is a code owner

@stephherbers stephherbers Awaiting requested review from stephherbers stephherbers will be requested when the pull request is marked ready for review stephherbers is a code owner

@Robert-Costello Robert-Costello Awaiting requested review from Robert-Costello Robert-Costello will be requested when the pull request is marked ready for review Robert-Costello is a code owner

@Jtang-1 Jtang-1 Awaiting requested review from Jtang-1 Jtang-1 will be requested when the pull request is marked ready for review Jtang-1 is a code owner

@nospame nospame Awaiting requested review from nospame nospame will be requested when the pull request is marked ready for review nospame is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esoergel @dimagimon