-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rc/only block conditonal alerts with ff #35511
Open
Robert-Costello
wants to merge
9
commits into
master
Choose a base branch
from
rc/only-block-conditonal-alerts-with-ff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+26
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: corehq/messaging/scheduling/models/content.py
Did you find this useful? React with a 👍 or 👎 |
catch up to base branch
Robert-Costello
requested review from
a team,
AddisonDunn,
minhaminha and
Jtang-1
and removed request for
a team
December 12, 2024 15:52
Robert-Costello
requested review from
orangejenny,
biyeun and
mkangia
as code owners
December 12, 2024 15:52
MartinRiese
reviewed
Dec 12, 2024
MartinRiese
approved these changes
Dec 12, 2024
Jtang-1
approved these changes
Dec 12, 2024
Jtang-1
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Jira ticket
The
BLOCKED_DOMAIN_EMAIL_SENDERS
FF was originally intended to block conditional alert emails from being sent. Later changes (linked in the ticket) resulted in all emails being blocked from domains using this FF. The flag is checked inget_valid_recipients
which previously depended only on the FF and the presence ofdomain
to determine whether to block emails. If a domain was passed in, the list of recipients returned would be empty. Those later changes made it so that a domain was always passed in, resulting in all emails, conditional alerts and system-related emails, being blocked.This adds an additional param,
is_conditional_alert
, to the "send" functions that is passed along toget_valid_recipients
.is_conditional_alert
is set by checkingEmailContent
for an associated case, which should only be present for conditional alerts.Feature Flag
BLOCKED_DOMAIN_EMAIL_SENDERS
and partially overlaps with RICH_TEXT_EMAILS
Safety Assurance
Safety story
Automated test coverage
QA Plan
no QA planned
Rollback instructions
Labels & Review