EmailSettings password encryption improvement [Migration] #35492
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
reindex/migration
Jtang-1
requested review from
jingcheng16,
gherceg,
a team,
AddisonDunn,
minhaminha and
Robert-Costello
and removed request for
a team
dimagimon
removed
the
reindex/migration
Jtang-1
force-pushed
the
jt+jc/encryption_improvement_migration
branch
from
bbc58d0 to
dbbd31b
Compare
dimagimon
added
the
reindex/migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
The migration related to this PR #35403
Feature Flag
Not specific to a feature flag but the model effected is only relevant for this feature flag https://www.commcarehq.org/hq/flags/edit/custom_email_gateway/
Safety Assurance
Safety story
Locally Tested
Automated test coverage
The coordinated previous PR tests that the function for reencryption from ECB to CBC on the EmailSettings model existing password field results in password being overwritten with the same plaintext password but cbc encrypted.
QA Plan
no QA
Migrations
PR that supports reading ECB and CBC encrypted password and starts writing new passwords as CBC encrypted
Rollback instructions
Labels & Review