Increase general workbook row limit to 1_048_576

[gherceg]

Product Description

Technical Summary

Followup to #35426

This is the row limit in Excel and makes more sense than arbitrarily picking 1 million rows. Ideally each feature will have a custom row limit that is appropriate for that workflow, so this is primarily meant as a fallback (as Daniel noted, it isn't really a fallback since this is the Excel limit, and in theory we will never see uploads larger than this...it is basically analogous to setting this limit to None).

Feature Flag

Safety Assurance

Safety story

Marginally increasing a limit. I don't think it is enough to make a meaningful difference to our infrastructure, especially since this limit was just rolled out.

Automated test coverage

QA Plan

No

Rollback instructions

• This PR can be reverted after deploy with no further considerations

Labels & Review

• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[millerdev]

Is this change necessary? If it's the limit for Excel then there's no way anyone could submit a file with more rows than this, right?

Or were you trying to put a limiting mechanism in place with the initial limit set as high as possible? Either way, I think it's fine to keep our limit at 1M rows.

[gherceg]

Or were you trying to put a limiting mechanism in place with the initial limit set as high as possible?

Yeah exactly. It felt a bit heavy handed to implement a generic limit that is lower than what it has effectively been without more research/comms, so agree this is effectively making this generic limit moot. If there are workflows where we can support the full 1,048,576 row limit that excel provides, it seems like a better UX to allow that than to arbitrarily limit it to 1 million rows.

This is all under the assumption that we are actively working on implementing specific row limits for features where we have experienced issues in the past, so the problematic areas will be addressed in the near future.

[millerdev]

Not sure why I didn't approve the first time.