Add Enterprise Case Management Report #35482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjriley
added
the
product/admin
mjriley
changed the title
nospame
previously approved these changes
Dec 6, 2024
| def app_query(self, domain): | ||
| return ( | ||
| AppES().domain(domain) | ||
| .filter(filters.term('doc_type', 'Application')) |
There was a problem hiding this comment.
Is this to make sure we don't get LinkedApplications or RemoteApps?
|
|
||
| def get_report_task(self, request): | ||
| account = BillingAccount.get_account_by_domain(request.domain) | ||
| return generate_enterprise_report.s( |
jingcheng16
reviewed
Dec 10, 2024
|
|
||
| @property | ||
| def headers(self): | ||
| return [_('Project Space'), _('# Applications'), _('# Surveys Only'), _('# Cases Only'), _('# Mixed')] |
There was a problem hiding this comment.
# of instead of # for the last 4 columns?
Comment on lines
+406
to
+411
| has_surveys = filters.nested('modules', filters.empty('modules.case_type.exact')) | ||
| has_cases = filters.nested('modules', filters.non_null('modules.case_type.exact')) | ||
|
|
||
| survey_only_count = app_query.filter(filters.AND(has_surveys, filters.NOT(has_cases))).count() | ||
| case_only_count = app_query.filter(filters.AND(has_cases, filters.NOT(has_surveys))).count() | ||
| mixed_count = app_query.filter(filters.AND(has_surveys, has_cases)).count() |
There was a problem hiding this comment.
Elegant... nice naming and nice logic
|
|
||
| case_management_percent = num_domains_using_case_management / num_domains_with_apps * 100 | ||
|
|
||
| return "{:.1f}%".format(case_management_percent) |
There was a problem hiding this comment.
I made a util function for display percentage with only one digit in 1aec926. Can reuse it after my PR is merged.
|
|
||
| REPORT_SLUG = EnterpriseReport.CASE_MANAGEMENT | ||
|
|
||
| def get_report_task(self, request): |
There was a problem hiding this comment.
this function can be removed as I moved get_report_task to base class in 5609175
| return bundle | ||
|
|
||
| def get_primary_keys(self): | ||
| return ('domain',) # very odd report that makes coming up with an actual key challenging |
There was a problem hiding this comment.
I think domain is a valid primary key in this case? Just don't get why it is challenging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Creates a new Enterprise Console Tile and API for the Case Management Report
Console:
Generated Report:
API:
Technical Summary
Associated ticket: https://dimagi.atlassian.net/browse/SAAS-16336. Also covers the Tile and API tickets.
Feature Flag
None
Safety Assurance
Safety story
Tested locally
Automated test coverage
Automated tests to be added later, once the logic is extracted from the report to a general location.
QA Plan
TBD
Rollback instructions
Labels & Review