Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force async processing for large data sources on restricted domains #35465

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

humanize number display

c579502
Select commit
Loading
Failed to load commit list.
Open

Force async processing for large data sources on restricted domains #35465

humanize number display
c579502
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Dec 13, 2024 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
This PR can be reverted after deploy with no further considerations Completed
Risk label is set correctly Completed
The set of people pinged as reviewers is appropriate for the level of risk of the change Completed
I was hesitant to process the data source asynchronously if it was not marked to do so Incomplete
I was hesitant to set something on the data source, which was created by the user & that too without the user knowing about it. We could else then mark it as async but also notify user we did so, along with explanation, which seemed to get too stretched for the implementation. So, I chose to rather tell the user to do so, which has an additional benefit of user getting aware of this feature and using it more actively in future. Incomplete