Command to requeue form repeaters using app_id, form_name and submission time #35457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaapstorm
reviewed
Dec 2, 2024
| """ | ||
| Parses the input CSV data, stripping any extra spaces around values. | ||
| """ | ||
| reader = csv.reader(csv_data.strip().splitlines()) |
There was a problem hiding this comment.
I think that fileinput in the standard library might be able to make this a little simpler.
import fileinput.. and then instead of sys.stdin.read() and ....splitlines() you can use this:
Suggested change
| reader = csv.reader(csv_data.strip().splitlines()) | |
| with fileinput.input() as csv_data: | |
| reader = csv.reader(csv_data) |
| def process_requeue_forms(self, requeue_forms, soft_run=True): | ||
| for extra, domain, app_id, form_name, form_xmlns, startdate, enddate, repeater_id in requeue_forms: | ||
| startdate = datetime.datetime.strptime(startdate, "%d-%m-%Y").date() | ||
| enddate = datetime.datetime.strptime(enddate, "%d-%m-%Y").date() |
There was a problem hiding this comment.
Oh boy, the Americans are going to be so confused. How about,
from datetime import date... and then
Suggested change
| enddate = datetime.datetime.strptime(enddate, "%d-%m-%Y").date() | |
| enddate = date.fromisoformat(enddate) |
? That way startdate and enddate can be formatted using any valid ISO 8601 format, e.g. "2024-11-30" or "20241130".
|
|
||
|
|
||
| class Command(BaseCommand): | ||
| help = "Requeue forms by inputting appi_id, form_name and submission times" |
There was a problem hiding this comment.
Typo
Suggested change
| help = "Requeue forms by inputting appi_id, form_name and submission times" | |
| help = "Requeue forms by inputting app_id, form_name and submission times" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Adhoc command to facilitate requeuing form repeaters
Technical Summary
Feature Flag
NA
Safety Assurance
Tested locally, relies on existing requeue functions
Safety story
Automated test coverage
NA
QA Plan
Tested locally
Rollback instructions
Labels & Review