Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rc/adjust input size #33838

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Rc/adjust input size #33838

merged 6 commits into from
Dec 5, 2023

Conversation

Robert-Costello
Copy link
Contributor

@Robert-Costello Robert-Costello commented Dec 4, 2023 •
edited
Loading

Product Description

This adds two appearance attributes short and medium that allow app builders to adjust the width of question inputs.

small:
Screenshot 2023-12-04 at 3 54 47 PM

medium:
Screenshot 2023-12-04 at 3 55 10 PM

DEFAULT(full container width):
Screenshot 2023-12-04 at 3 55 22 PM

Technical Summary

jira ticket: https://dimagi-dev.atlassian.net/browse/USH-3865
appearance attribute docs

Feature Flag

Safety Assurance

Safety story

change will only affect the width of inputs. tested locally.

Automated test coverage

QA Plan

no QA planned

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added the Risk: Medium Change affects files that have been flagged as medium risk. label Dec 4, 2023
@Robert-Costello Robert-Costello marked this pull request as ready for review December 4, 2023 21:46
Jtang-1
Jtang-1 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Jtang-1 Jtang-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. You probably already have this on your to do list, but this doc should also be updated

corehq/apps/cloudcare/static/cloudcare/js/form_entry/form_ui.js Outdated Show resolved Hide resolved
corehq/apps/cloudcare/static/cloudcare/js/form_entry/form_ui.js Outdated Show resolved Hide resolved
@Robert-Costello
Copy link
Contributor Author

You probably already have this on your to do list, but this doc should also be updated

Yes, on my todo, but thanks for the reminder!

@Jtang-1 Jtang-1 linked an issue Dec 5, 2023 that may be closed by this pull request
Blobdb error bug after restore on Ubuntu 22.04 #33367
Open
@Jtang-1 Jtang-1 removed a link to an issue Dec 5, 2023
Blobdb error bug after restore on Ubuntu 22.04 #33367
Open
@Jtang-1
Copy link
Contributor

Jtang-1 commented Dec 5, 2023

^ accidentally misclicked

@Robert-Costello Robert-Costello merged commit 1df6804 into master Dec 5, 2023
12 checks passed
@Robert-Costello Robert-Costello deleted the rc/adjust-input-size branch December 5, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jtang-1 Jtang-1 Jtang-1 approved these changes

@stephherbers stephherbers Awaiting requested review from stephherbers stephherbers is a code owner

@nospame nospame Awaiting requested review from nospame nospame is a code owner

Assignees
No one assigned
Labels
Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robert-Costello @Jtang-1 @dimagimon