Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sr/linkw sub #32493

Closed
wants to merge 5 commits into from
Closed

Sr/linkw sub #32493

wants to merge 5 commits into from

Conversation

sravfeyn
Copy link
Member

Product Description

Technical Summary

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Migrations

  • The migrations in this code can be safely applied first independently of the code

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@sravfeyn sravfeyn added the Open for review: do not merge A work in progress label Jan 17, 2023
@dimagimon dimagimon added the reindex/migration Reindex or migration will be required during or before deploy label Jan 17, 2023
@sravfeyn
Copy link
Member Author

Only as an example for #32482

@sravfeyn sravfeyn closed this Jan 17, 2023
@sravfeyn sravfeyn reopened this Jan 17, 2023
biyeun
biyeun requested changes Jan 17, 2023
View reviewed changes
Copy link
Member

@biyeun biyeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sravfeyn! Could you please add tests for the new management command? Thanks! ^_^

@sravfeyn
Copy link
Member Author

This was only to demonstrate how complicated this approach is in #32482

@sravfeyn sravfeyn closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biyeun biyeun biyeun requested changes

@orangejenny orangejenny Awaiting requested review from orangejenny orangejenny is a code owner

@dannyroberts dannyroberts Awaiting requested review from dannyroberts dannyroberts is a code owner

Assignees
No one assigned
Labels
Open for review: do not merge A work in progress reindex/migration Reindex or migration will be required during or before deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sravfeyn @biyeun @dimagimon