Remove FORM_LINK_WORKFLOW toggle, enable it by default #32402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravfeyn
added
the
product/all-users-all-environments
|
Todo: To merge https://confluence.dimagi.com/pages/viewpage.action?spaceKey=saas&title=Form+Link+Workflow+Feature+Flag into https://confluence.dimagi.com/display/commcarepublic/End+of+Form+Navigation after this PR is merged. |
|
Closing this in favour of #32431 as the feature needs to be available for standard plans and above only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
This removes the FORM_LINK_WORKFLOW toggle and enables it by default to all domains within the existing End of Form Navigation feature.
https://dimagi-dev.atlassian.net/browse/SC-2410
Technical Summary
Feature Flag
Removed FORM_LINK_WORKFLOW toggle
Safety Assurance
Should be safe without any migrations and such
Safety story
I have tested this locally for apps built with toggle enabled previously before removing the toggle and I have tested that the feature works without the toggle for fresh apps.
Automated test coverage
Tests exists
QA Plan
NA, I have done UI tests myself as they are minimal
Rollback instructions
If the toggle deletion needs to be reverted we need to identify domains that start using the feature without the toggle and then enable the toggle for those domains after reverting
Labels & Review