Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert breaking prometheus changes to gunicorn_conf.py #26911

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

dannyroberts
Copy link
Member

@dannyroberts dannyroberts commented Mar 19, 2020

SUMMARY

Reverts this aspect of: #26876

FEATURE FLAG
PRODUCT DESCRIPTION

@dannyroberts dannyroberts added the product/invisible Change has no end-user visible impact label Mar 19, 2020
@dannyroberts dannyroberts merged commit c04952c into master Mar 19, 2020
@dannyroberts
Copy link
Member Author

@snopoke I expect you'll want to add this back, the offending failure was

Traceback (most recent call last):
  File "/home/cchq/www/staging/releases/2020-03-19_20.33/python_env-3.6/bin/gunicorn", line 10, in <module>
    sys.exit(run())
  File "/home/cchq/www/staging/releases/2020-03-19_20.33/python_env-3.6/lib/python3.6/site-packages/gunicorn/app/wsgiapp.py", line 58, in run
    WSGIApplication("%(prog)s [OPTIONS] [APP_MODULE]").run()
  File "/home/cchq/www/staging/releases/2020-03-19_20.33/python_env-3.6/lib/python3.6/site-packages/gunicorn/app/base.py", line 219, in run
    super().run()
  File "/home/cchq/www/staging/releases/2020-03-19_20.33/python_env-3.6/lib/python3.6/site-packages/gunicorn/app/base.py", line 72, in run
    Arbiter(self).run()
  File "/home/cchq/www/staging/releases/2020-03-19_20.33/python_env-3.6/lib/python3.6/site-packages/gunicorn/arbiter.py", line 198, in run
    self.start()
  File "/home/cchq/www/staging/releases/2020-03-19_20.33/python_env-3.6/lib/python3.6/site-packages/gunicorn/arbiter.py", line 138, in start
    self.cfg.on_starting(self)
  File "deployment/gunicorn/gunicorn_conf.py", line 29, in on_starting
    for f in glob.glob(os.path.join(path, '*.db')):
  File "/home/cchq/www/staging/releases/2020-03-19_20.33/python_env-3.6/lib/python3.6/posixpath.py", line 80, in join
    a = os.fspath(a)
TypeError: expected str, bytes or os.PathLike object, not NoneType

on gunicorn start up (but not runserver) which I traced back to this. I think as a precaution, any fix you add here you should make sure to deploy to staging just to make sure, sound good?

@snopoke snopoke deleted the dmr/revert-breaking-part-of-26876 branch March 20, 2020 07:10
@snopoke
Copy link
Contributor

snopoke commented Mar 20, 2020

Thanks @dannyroberts. I had tested this locally but must have not cleared the env var properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants