Merge pull request #26894 from saiprakash-v/sdd-url-reset

ICDS Dashboard: removing additional request params added to url after request completion
dimagi · Mar 19, 2020 · 4980bc0 · 4980bc0
2 parents 2faa5ec + 85e6e89
commit 4980bc0
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/...s/static/js/directives/service-delivery-dashboard/service-delivery-dashboard.directive.js b/...s/static/js/directives/service-delivery-dashboard/service-delivery-dashboard.directive.js
@@ -461,7 +461,10 @@ function ServiceDeliveryDashboardController($rootScope, $scope, $http, $location
     // end mobile helpers
 
     vm.getData = function () {
-        var requestParams = $location.search();
+        // If $location.search() is directly assigned to requestParams variable, It is assigned along with reference.
+        // So, any change made to requestParams will be reflected in $location also (affecting the url). To avoid this,
+        // we are deep cloning the object ($location.search()) before assigning it to request params
+        var requestParams = JSON.parse(JSON.stringify($location.search()));
         if (isMobile) {
             var mobileCustomParams = vm.getMobileCustomParams();
             for(var k in mobileCustomParams) {