Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Payments Import issues #492

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Address Payments Import issues #492

wants to merge 3 commits into from

Conversation

sravfeyn
Copy link
Member

Product Description

https://dimagi.atlassian.net/browse/CCCT-653

  • Makes payment import async to make it clear to users when it's processing
    • By adding a celery util to propagate task progress
  • Fixes exchange-rate calc to be based on payment-date
  • Handles multiple payments to same user

Technical Summary

Safety Assurance

Safety story

Tested locally

Automated test coverage

Tests exist

QA Plan

NA

Labels & Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@sravfeyn
Copy link
Member Author

@calellowitz

@sravfeyn sravfeyn changed the title Sr/asyncpay Address Payments Import issues Feb 14, 2025
@sravfeyn
Copy link
Member Author

sravfeyn commented Mar 3, 2025

@calellowitz Bumping for visibility

@sravfeyn sravfeyn requested review from calellowitz, pxwxnvermx and hemant10yadav and removed request for calellowitz and pxwxnvermx March 3, 2025 12:02
@@ -0,0 +1,7 @@
def set_task_progress(task, message, is_complete=False):
task.update_state(state="SUCCESS" if is_complete else "PROGRESS", meta={"message": message})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we make these task statuses Constants? That will make it easier for referencing in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants