Refactor report base class #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxwxnvermx
approved these changes
Feb 11, 2025
| @@ -5,7 +5,7 @@ | |||
| {% load crispy_forms_tags %} | |||
|
|
|||
| {% block content %} | |||
| <h1>Delivery Stats Report</h1> | |||
| <h1>{{ report_title }}</h1> | |||
There was a problem hiding this comment.
nit: can we add a check to remove this section when the report_title variable is not set in reports?
|
@calellowitz Bumping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
This refactor is already PRed in another larger PR. This refactor helps write more DRYer reports. Taking this out of larger PR, so that it doesn't need to wait for it to be merged.
Technical Summary
Safety Assurance
Safety story
This is a simple refactor and I have tested that the refactored report works okay.
Automated test coverage
QA Plan
NA
Labels & Review