capture user/org tags in sentry #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxwxnvermx
approved these changes
Dec 9, 2024
calellowitz
reviewed
Dec 10, 2024
commcare_connect/utils/middleware.py
Outdated
| def process_view(self, request, view_func, view_args, view_kwargs): | ||
| from sentry_sdk import configure_scope | ||
|
|
||
| with configure_scope() as scope: |
There was a problem hiding this comment.
Why use this pattern instead of the one shown in the docs using get_current_scope or just sentry_sdk.set_tag? Is there a difference between them. I can't actually find this one in the docs.
There was a problem hiding this comment.
On further look, it looks like this function is deprecated https://docs.sentry.io/platforms/python/migration/1.x-to-2.x#custom-instrumentation
There was a problem hiding this comment.
I have updated it to use set_user and set_tag. (Previously I adapted this from HQ which was using 2.8 )
|
@calellowitz Does this look good now? |
pxwxnvermx
approved these changes
Jan 6, 2025
calellowitz
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easy to trace 500s when users report issues.