Claim Limit Remaining Budget Fix #445
Open
+51
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravfeyn
approved these changes
Dec 5, 2024
hemant10yadav
approved these changes
Dec 5, 2024
calellowitz
reviewed
Dec 5, 2024
There was a problem hiding this comment.
This feels backwards. Shouldn't claimed budget account for the org pay (since we are reserving that part of the budget as well), rather than have remaining budget ignore org pay. I think the end result will be the same, but it seems more correct to say the org pay was claimed, and remaining, rather than excluding it from both
calellowitz
reviewed
Dec 16, 2024
| def test_opportunity_stats(opportunity: Opportunity, user: User): | ||
| payment_unit_sub = PaymentUnitFactory( | ||
| payment_unit_sub = PaymentUnitFactory.create( |
There was a problem hiding this comment.
What does this change do
| payment_units = [payment_unit_sub, payment_unit1, payment_unit2] | ||
| budget_per_user = sum(pu.max_total * pu.amount for pu in payment_units) | ||
| org_pay = 0 | ||
| if opportunity.managed: |
There was a problem hiding this comment.
Shouldn't we know if the opportunity is managed or not in the test?
| if opportunity.managed: | ||
| org_pay = opportunity.managedopportunity.org_pay_per_visit | ||
| budget_per_user += sum(pu.max_total * org_pay for pu in payment_units) | ||
| opportunity.total_budget = budget_per_user * 3 |
There was a problem hiding this comment.
why are we modifying the opportunity in the test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining budget calculation for Managed Opportunities was off due to the org_pay component added to the total budget. To calculate the effective user total budget we have to remove the org_pay component from the total budget, then this user total budget can be used to calculate the remaining budget.
This PR will fix the remaining budget calculation and also fix the bug related to Opportunity Claims getting created for users in opportunities where the budget is exhausted.
Ticket