Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Over Limit Changes #434

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Over Limit Changes #434

wants to merge 9 commits into from

Conversation

pxwxnvermx
Copy link
Contributor

@pxwxnvermx pxwxnvermx commented Nov 15, 2024 •
edited
Loading

Product Description

Mobile User Facing Changes:

  • Progress is now evaluated based only on the approved visits.

Web User Facing Changes:

  • Added a warning message when more visits than the max_daily and max_total amount permitted for a deliver unit are approved.

Technical Summary

Ticket

Safety Assurance

Safety story

  • Deployed and tested on staging.

Automated test coverage

  • Added an automated test to check the over-limit count message on visit import.

QA Plan

  • Going to request QA on this ticket.

Labels & Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@pxwxnvermx pxwxnvermx self-assigned this Nov 15, 2024
@pxwxnvermx pxwxnvermx force-pushed the pkv/over-limit-changes branch from 439b2d2 to 512b049 Compare November 19, 2024 10:23
@pxwxnvermx pxwxnvermx marked this pull request as ready for review January 17, 2025 08:47
@pxwxnvermx
Copy link
Contributor Author

@calellowitz @sravfeyn @hemant10yadav can you please review this PR? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sravfeyn sravfeyn Awaiting requested review from sravfeyn

@calellowitz calellowitz Awaiting requested review from calellowitz

@hemant10yadav hemant10yadav Awaiting requested review from hemant10yadav

Assignees

@pxwxnvermx pxwxnvermx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pxwxnvermx