Make slack deploy diff work for longer diffs as well #6460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We sometimes do not receive diffs during deploy so they have to be manually copied. On looking I found out it is because of the 3000 charachter limit on the message. The fix that is made here is chunking the longer messages and sending as seperate messages on slack
snopoke
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Another option would be to send the diff as a file: https://api.slack.com/messaging/files#upload
|
That could have been one of the approach but I was not sure if Slack would render markdown files in the same way it renders markdown messages. |
|
⭐ 🏆 ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes do not receive diffs during deploy so they have to be manually copied. On looking I found out it is because of the 3000 character limit on the message. The fix that is made here is chunking the longer messages and sending as separate messages on slack
This is how the diffs will look like.
There was another approach that I experimented with, which was sending different blocks in the same message like this
In both the approaches the messages are getting truncated under
See More. For the second approach theSee Moreis hidden in the diff and hard to find. Although first approach is still not the best but it provides a good differentiation between the messages.Environments Affected
Prod and India