Deploy stack improvements #6456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkangia
commented
Jan 2, 2025
| register: result | ||
| until: not result.failed or 'Connection refused' not in result.msg | ||
| retries: 5 | ||
| delay: 10 |
There was a problem hiding this comment.
Copied from the retry configuration in the following task. Though chosen a shorter waiting time since 20 seconds seemed a bit of overkill.
mkangia
commented
Jan 2, 2025
| @@ -82,6 +82,7 @@ | |||
| - meta: flush_handlers | |||
|
|
|||
| - name: Add nodes | |||
| no_log: true | |||
There was a problem hiding this comment.
this resolves the warning
[WARNING]: Module did not set no_log for password
AmitPhulera
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dimagi.atlassian.net/browse/SC-4038
Couple of improvements noticed while testing a full stack deploy.
Environments Affected
All
This change is applicable to all environments but won't change anything about how they are setup since the changes are for the setup process and not for any actions taken during the setup