CCCT-580 || Payment card tap issue in delivery progress screen #2922
Conversation
Solved tap issue on payment card in delivery progress screen
📝 WalkthroughWalkthroughThe pull request introduces modifications to two primary files: In the Java adapter class, the click event handling has been updated to respond to clicks on the entire Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
app/res/layout/connect_delivery_progress_item.xml (3)
11-14: Consider using dp units for shadow properties.Shadow properties should use dp units instead of raw numbers for consistent appearance across different screen densities.
- android:shadowDx="30" - android:shadowDy="30" - android:shadowRadius="50" + android:shadowDx="8dp" + android:shadowDy="8dp" + android:shadowRadius="12dp"
Line range hint
77-93: Consider extracting dimensions to dimens.xml.Hard-coded dimensions like text sizes, margins, and paddings should be defined in dimens.xml for better maintainability and consistency.
Example structure for dimens.xml:
<resources> <!-- Text sizes --> <dimen name="text_size_small">11sp</dimen> <dimen name="text_size_medium">12sp</dimen> <!-- Margins --> <dimen name="margin_small">3dp</dimen> <dimen name="margin_medium">6dp</dimen> </resources>Also applies to: 131-139
Line range hint
154-161: Verify RTL support for right margin.The
android:layout_marginRightattribute should be replaced withandroid:layout_marginEndfor proper RTL support.- android:layout_marginRight="10dp" + android:layout_marginEnd="10dp"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/res/layout/connect_delivery_progress_item.xml(4 hunks)app/src/org/commcare/adapters/ConnectDeliveryProgressReportAdapter.java(1 hunks)
🔇 Additional comments (2)
app/src/org/commcare/adapters/ConnectDeliveryProgressReportAdapter.java (1)
51-53: LGTM! Improved tap target accessibility.
Moving the click listener from the arrow icon to the entire card view (rootView) improves accessibility by:
- Providing a larger tap target
- Making the interaction more intuitive
- Following material design guidelines for card interactions
app/res/layout/connect_delivery_progress_item.xml (1)
4-16: LGTM! Proper implementation of material design card interaction.
The CardView is now properly configured for touch interaction with:
- Clickable and focusable properties
- Ripple effect feedback via selectableItemBackground
- Visual elevation through shadows
Solved tap issue on payment card in delivery progress screen
Summary
https://dimagi.atlassian.net/browse/CCCT-580
Feature Flag
Product Description
PR Checklist
Automated test coverage
Safety story