Upgrade to apache-superset==3.1.0 #33
Conversation
kaapstorm
force-pushed
the
nh/superset_3.1.0
branch
from
236331c to
bfe30af
Compare
setup.py
Outdated
| 'jinja2==3.1.2', | ||
| 'psycopg2==2.9.6', | ||
| 'requests==2.31.0', | ||
| 'sentry-sdk==1.39.2', |
There was a problem hiding this comment.
If we use sentry-sdk[flask], then we don't have to install blinker
|
Nice! |
| 'WTForms==2.3.3', | ||
| 'cryptography==37.0.4', | ||
| 'sentry-sdk==1.9.10', | ||
| 'apache-superset==3.1.0', |
There was a problem hiding this comment.
Shouldn't we be using our forked superset? This would break some of the features we have implemented already. Specifically this dimagi/superset#1 (which allows users to see UCR name instead of the data table UUID in List Data Sources page)
There was a problem hiding this comment.
There is few docs I added that explain how to build an updated forked package ahttps://github.com/dimagi/hq_superset/blob/master/apache-superset.md
We would need to use the fork repo instead of the core repo.
There was a problem hiding this comment.
Thank you for the feedback!
This resolves some of my confusion: As you can see from the master branch of dimagi-superset, there is only one commit difference between it and apache-superset. And that commit has some Portuguese translations (which cannot be rebased on top of Superset 3.1.0 because of unresolveable conflicts).
It introduces more questions though. I'll follow them up offline. I'm very sorry that I missed that documentation!
There was a problem hiding this comment.
hey @kaapstorm
Just confirming that we are now using the apache superset only or its a temporary change?
There was a problem hiding this comment.
It's a temporary change. I have uploaded dimagi-superset 3.1.0 to PyPI just now, and I'll update these requirements.
Upgrades hq_superset to apache-superset==3.1.0
This required a few tweaks:
superset.dataset.commandsmoved tosuperset.commands.datasetis_user_admin()becamesecurity_manager.is_admin()get_sqla_engine()method becameget_sqla_engine_with_context()context manager.That was about it.