Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed polyfills file #1126

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Removed polyfills file #1126

merged 1 commit into from
Oct 24, 2024

Conversation

orangejenny
Copy link
Contributor

Summary

String.startswith and String.endswith have had good browser support for a while now: https://caniuse.com/mdn-javascript_builtins_string_startswith

Safety Assurance

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change
  • If QA is part of the safety story, the "Awaiting QA" label is used
  • I have confidence that this PR will not introduce a regression for the reasons below

Automated test coverage

N/A - removal of unused code

QA Plan

not requesting QA

Safety story

removal of unused code

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

@orangejenny orangejenny requested a review from millerdev October 23, 2024 19:22
@orangejenny orangejenny merged commit 80cab1f into master Oct 24, 2024
2 checks passed
@orangejenny orangejenny deleted the jls/kill-polyfills branch October 24, 2024 18:02
@orangejenny orangejenny mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millerdev millerdev millerdev approved these changes

Assignees
No one assigned
Labels
product/invisible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orangejenny @millerdev