Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded requirejs from 2.36 to 2.37 #1124

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

orangejenny
Copy link
Contributor

@orangejenny orangejenny commented Sep 16, 2024

Summary

https://dimagi.atlassian.net/browse/SAAS-15983

HQ was done in dimagi/commcare-hq#34917

Safety Assurance

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change
  • If QA is part of the safety story, the "Awaiting QA" label is used
  • I have confidence that this PR will not introduce a regression for the reasons below

Automated test coverage

There is test coverage, I'll also smoke test on staging.

QA Plan

no

Safety story

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Copy link
Contributor

@gherceg gherceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always miss CVEs for vellum. Thank you! Remind me, would vellum end up using the version of RequireJS set in HQ, or are the versions of their dependencies independent of one another?

@orangejenny
Copy link
Contributor Author

They're independent - Vellum had requirejs long before HQ. Check out here and here to see how it gets loaded.

@orangejenny orangejenny merged commit c554517 into master Sep 16, 2024
2 checks passed
@orangejenny orangejenny deleted the jls/upgrade-requirejs branch September 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants