Fix feedback cache invalidation #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melegiul
force-pushed
the
bugfix/feedback-cache
branch
from
412333a to
b39d2b6
Compare
timobrembeck
added
prio: medium
melegiul
force-pushed
the
bugfix/feedback-cache
branch
2 times, most recently
from
f9e43ca to
1247abb
Compare
|
Code Climate has analyzed commit 03a332b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 46.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.0% (-0.2% change). View more on Code Climate. |
- Cache invalidation via signals on feedback creation and deletion - Cache invalidation in views on feedback update
melegiul
force-pushed
the
bugfix/feedback-cache
branch
from
1247abb to
03a332b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Fix feedback cache invalidation
Proposed changes
django-cacheops does not support multi-table inheritance (Suor/django-cacheops#31)
The suggested workaround is to use signal handlers to invalidate the cache manually (Suor/django-cacheops#31 (comment)), so signal handlers are used to invalidate the cache on feedback creation and deletion.
But marking feedback as read/unread uses the query set update method and does not trigger a save signal, so in case of feedback updates cache invalidation is performed in the view instead.
Resolved issues
Fixes: #1282