-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2786: Upgrade react native to v0.74 #2907
Conversation
4df3b80
to
c079146
Compare
75cc6d9
to
4f06cfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, i expect these changes are all the changes from react native updater.
Most of them, yes. A few libraries I had to update manually after. |
2786: Upgrade dependencies
Code Climate has analyzed commit 64e8fbb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.2%. View more on Code Climate. |
Short description
Upgrade react native to v0.74.
I upgraded dependencies in #2912, so if you review both PRs at the same time, you only need to test #2912.
Switching to yarn modern as proposed by react-native will not be done as the memory/oom issue in the CI is still open.
Upgrading to react-native v0.75 is currently blocked by react-native-static-server(https://github.com/birdofpreyru/react-native-static-server) as the version we are currently using is not compatible and new versions require a higher minSDK version.
Proposed changes
Side effects
Hopefully none.
Testing
Nothing. Testing should be done with #2912 as both PRs will be merged together.
Resolved issues
Partly fixes: #2786.