Vcoman/ces demo #14
Open
Vcoman/ces demo #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Coman <[email protected]>
Signed-off-by: Victor Coman <[email protected]>
Signed-off-by: Victor Coman <[email protected]>
… each time the application is restarted Signed-off-by: Victor Coman <[email protected]>
-before it gave an exception, now it returns true Signed-off-by: Victor Coman <[email protected]>
| return get_next_random(wind, WIND_MAX, WIND_MIN, WIND_DELTA) | ||
| else: | ||
| # Conversion from miles/h to km/h | ||
| return round(wind * 1.609, 1) |
There was a problem hiding this comment.
It would be more elegant to have a separated function to convert to km/h and call it here.
| wind_dir = meas_items["current_windDirection_List"] | ||
| luminosity = meas_items["lightVal"] | ||
|
|
||
| # meas_data = [temp, moist, pres, rain, wind, wind_dir, luminosity] |
There was a problem hiding this comment.
Remove these comments
| status_task() | ||
|
|
||
| # TODO: Remove for final version as main controller is set in the provisioning step. | ||
| set_main_controller(True) |
There was a problem hiding this comment.
Should this be removed, then?
hgonzaleDigi
approved these changes
Dec 21, 2021
diescalo
approved these changes
Dec 21, 2021
| # Reset the rain at midnight. | ||
| if (current_time + time_factor) // SECONDS_PER_DAY > 0: | ||
| # Create and configure the serial port settings | ||
| ser = serial.Serial() |
There was a problem hiding this comment.
Doesn't this instantiation conflict with the port created in the read_microbit() method? Maybe we should declare the serial port as global and use it in both methods.
|
|
||
| global device, current_time | ||
|
|
||
| # Create and configure the serial port settings |
There was a problem hiding this comment.
Duplicated block of code, it would be better to have a method that resets the microbit board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.