Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new ToolMetadata type to the uncertainty_engine_types package. The type provides a structured way to store and validate metadata about tools, specifically their inputs and outputs at the node/handle level.
- Adds a new
ToolMetadataPydantic model with nested dictionaries mapping NodeId -> HandleLabel -> NodeInputInfo/NodeOutputInfo - Implements validation methods (
is_empty(),has_partial_data(),validate_complete()) to ensure metadata completeness - Includes comprehensive test coverage with 9 test cases covering all validation scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uncertainty_engine_types/tool_metadata.py | New file introducing the ToolMetadata class with inputs/outputs fields and validation methods |
| uncertainty_engine_types/init.py | Added import and export of ToolMetadata type |
| tests/test_tool_metadata.py | Comprehensive test suite covering empty, partial, and complete metadata validation scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cariad
reviewed
Dec 22, 2025
cariad
reviewed
Dec 22, 2025
cariad
reviewed
Dec 22, 2025
Contributor
Author
|
Thanks @cariad, agree with those suggestions. I'll go make some changes 🔧 |
cariad
reviewed
Dec 22, 2025
cariad
approved these changes
Dec 22, 2025
Contributor
cariad
left a comment
There was a problem hiding this comment.
Really nice use of those new test fixtures! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR introduces
ToolMetadatatype, important for use within the SDK, tool node and in future the resource service.Has helper functions for checking if metadata is empty or incomplete. Useful for before saving a workflow to check the ToolMetadata is complete and valid before saving.