-
Notifications
You must be signed in to change notification settings - Fork 23
docs: fix documentation rendering with scikit-package
standards.
#64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: migration
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbillinge, it's ready for review.
@@ -1,3 +1,3 @@ | |||
{ | |||
"path": "../../../../examples/QPA-Quantitative phase analysis.ipynb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples with .ipynb
files are moved from the top-level directory into the docs
directory, as other diffpy
packages do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be in the top level tbh. These are examples for users, not source for docs so it doesn't make so much sense to me to put them into docs/source. It kind of depends whether the examples are just going to appear in the rst or whether we expect users to be able to import and run them. They won't get bundled in the release, but at least they are more accessible (in docs/examples
in the repo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, scratch my comment. As long as it is docs/examples
I am happy...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -32,7 +32,7 @@ was developed by V. Favre-Nicolin as part of the development of the | |||
Further developments including the ability to index and refine | |||
powder patterns, solve and display crystal structures, using the | |||
global optimisation and least squares algorithms (see the | |||
:doc:`examples/index`) are provided by Vincent Favre-Nicolin (ESRF). | |||
:doc:`examples/examples`) are provided by Vincent Favre-Nicolin (ESRF). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples/index.rst
is renamed to examples/examples.rst
.
@sbillinge , is it ready for merging? |
Who should I add as maintainer on readthedocs, so you can also test the version generated there ? |
@ycexiao This will produce a |
@Tieqiong, thank you. After running
I get
I also tried to install
Could you please help me with the installation problem? |
@vincefn please could you add me (@sbillinge ) |
@vincefn quick question. Do you mind if we move |
What problem does this PR address?
Fix the documentation rendering.
What should the reviewer(s) do?
Please check the rendered documentation.


