Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Jun 11, 2025

Final PR for the current skpkg'ing of diffpy.utils! After this is merged we should be able to merge migration into main once tested.

I had to install sphinx-copybutton to build docs locally so i added that to requirements. Maybe this needs to be added to scikit-package?

@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b14be77) to head (9f3e153).
Report is 8 commits behind head on migration.

Additional details and impacted files
@@             Coverage Diff             @@
##           migration      #344   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              9         9           
  Lines            516       516           
===========================================
  Hits             516       516           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

I had to install sphinx-copybutton to build docs locally so i added that to requirements. Maybe this needs to be added to scikit-package?

I believe it is already in scikit-package v0.1.0. It is just you built your env using requirements/docs.txt before updating.....

@cadenmyers13
Copy link
Contributor Author

@sbillinge Oh you're right, I must've got rid of it when I moved requirements over!

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I am confused now, because I believe that copybutton is in skpkg 0.1.0 so I am not sure why you are having to manually add it here. Please see my other comment and then I an merge.

@cadenmyers13
Copy link
Contributor Author

@sbillinge see above response about copybutton, it was a fault on my end!

@sbillinge
Copy link
Contributor

@sbillinge Oh you're right, I must've got rid of it when I moved requirements over!

slow and steady wins the race!

@sbillinge sbillinge merged commit 86e59be into diffpy:migration Jun 11, 2025
4 checks passed
@sbillinge
Copy link
Contributor

Brilliant, is that a wrap (bar testing)?

@cadenmyers13 cadenmyers13 deleted the news-and-misc branch June 11, 2025 19:06
@cadenmyers13
Copy link
Contributor Author

@sbillinge yep!

@cadenmyers13
Copy link
Contributor Author

@sbillinge pytest passes on a fully sync'd migration branch. Is there any other testing that needs to be done?

Screenshot 2025-06-11 at 3 32 59 PM

@sbillinge
Copy link
Contributor

normally we would quickly run through any tutorial. Could you take a look if there is one? But then we can merge. I htink you can create a PR, migration -> main when you are ready.

@sbillinge
Copy link
Contributor

@cadenmyers13 don't forget the "closes #" close the skpkg issue for that migration -> main PR.

@cadenmyers13
Copy link
Contributor Author

@cadenmyers13 don't forget the "closes #" close the skpkg issue for that migration -> main PR.

@sbillinge will do. There are tutorials for this. ill run them and let you know if i run into any bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants