Skip to content

Conversation

@zmx27
Copy link
Contributor

@zmx27 zmx27 commented Oct 26, 2025

No description provided.

@zmx27
Copy link
Contributor Author

zmx27 commented Oct 26, 2025

@sbillinge ready for review

@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.00%. Comparing base (3eabaa9) to head (7b94432).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   50.00%   50.00%           
=======================================
  Files           2        2           
  Lines          18       18           
=======================================
  Hits            9        9           
  Misses          9        9           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit db1b76c into diffpy:main Oct 26, 2025
4 checks passed
@sbillinge
Copy link
Contributor

@zmx27 I think I may be getting to the bottom of the installation issue. Please can you try again with a clean environment?

The install scripts need a bit of tlc, they seem to not be working fully automatically for some reason, but if I then fix the errors with manual installation commands I can get it to work now. Please can you try and report hte errors? An issue seems to be that setuptools version is looking for tags to get version number. I fixed the issues with srxplanar by pushing a 0.0.1 tag to upstream, but it may still fail for you if any of the other repos need similar tlc. This seems to b a bit brittle!

@zmx27
Copy link
Contributor Author

zmx27 commented Oct 26, 2025

I don't think it works still on my side... here are the commands I ran this time:
bash install_py3.sh --> creates a clean xpdfsuite313 again after I deleted it prior to running this, all of the other dependencies are installed successfully
bash pip_install.sh --> all of the sub packages are installed successfully once again, but xpdfsuite still refuses to install with the following error:

Obtaining file:///Users/zhimingxu/BillingeGroup/diffpy.xpdfsuite/diffpy.xpdfsuite
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... error
  error: subprocess-exited-with-error

  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [47 lines of output]
      Traceback (most recent call last):
        File "/Users/zhimingxu/miniconda3/envs/xpdfsuite313/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
          main()
          ~~~~^^
        File "/Users/zhimingxu/miniconda3/envs/xpdfsuite313/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
          json_out["return_val"] = hook(**hook_input["kwargs"])
                                   ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
        File "/Users/zhimingxu/miniconda3/envs/xpdfsuite313/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 157, in get_requires_for_build_editable
          return hook(config_settings)
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 473, in get_requires_for_build_editable
          return self.get_requires_for_build_wheel(config_settings)
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 331, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 301, in _get_build_requires
          self.run_setup()
          ~~~~~~~~~~~~~~^^
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 317, in run_setup
          exec(code, locals())
          ~~~~^^^^^^^^^^^^^^^^
        File "<string>", line 1, in <module>
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools/__init__.py", line 115, in setup
          return distutils.core.setup(**attrs)
                 ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools/_distutils/core.py", line 148, in setup
          _setup_distribution = dist = klass(attrs)
                                       ~~~~~^^^^^^^
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools/dist.py", line 321, in __init__
          _Distribution.__init__(self, dist_attrs)
          ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools/_distutils/dist.py", line 309, in __init__
          self.finalize_options()
          ~~~~~~~~~~~~~~~~~~~~~^^
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools/dist.py", line 784, in finalize_options
          ep(self)
          ~~^^^^^^
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools_git_versioning.py", line 257, in infer_version
          version = version_from_git(dist.metadata.name, **config, root=root)
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools_git_versioning.py", line 619, in version_from_git
          return _sanitize_version(version)
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/setuptools_git_versioning.py", line 470, in _sanitize_version
          result = str(Version(sanitized_version))
                       ~~~~~~~^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/t3/dstc1gt93zs25q6y4b30z1nh0000gn/T/pip-build-env-u_36aqb_/overlay/lib/python3.13/site-packages/packaging/version.py", line 202, in __init__
          raise InvalidVersion(f"Invalid version: {version!r}")
      packaging.version.InvalidVersion: Invalid version: 'pre.release'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

Note that I've pulled the latest updates from xpdfsuite's main branch before running these. You mentioned that you fixed the issues in srxplanar by pushing a tag to upstream, and that something similar may need to be done for the other repos. Is there some way I can help?

@sbillinge
Copy link
Contributor

Ok, good. Please can you now check the repos of each of the sub-packages and look for tags that is "pre-release" and let me know if you find it

@zmx27
Copy link
Contributor Author

zmx27 commented Oct 27, 2025

I've checked the repos of the sub packages, and I don't think I saw any tags that is specifically "pre-release." However, I did see that you pushed tags to certain repos with a "rc" tag, and I'm assuming that these are the pre-releases tags you are referring to. The repos that still has a "rc" tag are distanceprinter(0.0.1-rc.0) and srxplanargui(1.0.0-rc.0).
Also, it seems like xpdfsuite has an rc tag as well, while srxplanar hasn't had any new tags since 2014.

@sbillinge
Copy link
Contributor

no, we are looking for a tag that is actually 'pre-release'. The rc tags are different. These are real attempts at running releases.

@zmx27
Copy link
Contributor Author

zmx27 commented Oct 27, 2025

I do not see any tags that are "pre-release" in that case

@sbillinge
Copy link
Contributor

I do not see any tags that are "pre-release" in that case

did you try again in a clean env? I made some pushes over the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants