-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to pyproject #26
base: main
Are you sure you want to change the base?
Conversation
I have an issue with installation. It says no module found "numpy" on install, if using venv (numpy is installed actually). Does this PR solves it? |
No, this update fixes errors with build. It is possible if you are using the new Mac chips that this program is not currently compatible. Othsrwise, check that your numpy is installed with the correct python binary ( |
Were you able to identify the GIL issue? I've build this lib for own use case and for python 3.10.14. I had to build latest build for it specifically and rebuild libdiffpy as well. It's running now on latest macos for me but I'm also faicing this issue:
Interesting enough, following your lead of that this is caused by |
Unfortunately, this is where I am stuck too. I will report any findings to this thread, and feel free to do so as well if you find anything new. Hope to get this resolved together! |
Please see #28 for the Python GIL error fix. |
Issue relating to GIL related to
subtype_dealloc
of aCovalentRadiiTable
object. Still looking into exactly where. While looking for the error, I made a few changes to the source and build code.numpy
update (numpy.complex128
)pkgutils
andnumpy.distutils
usagesetup.py
topyproject.toml
as possible (extensions must remain insetup.py
)Build has been tested on the GCP (works and
pytest
tests pass for 3.9+ disregarding the GIL issues). Some instructions on common errors have been written to the group wiki.