Skip to content

Conversation

@Sparks29032
Copy link
Collaborator

Update to #250, which would throw a warning each step of the refinement. We only want the user to see the warning afterward since only that quantity is useful.

Targets first check point of #243

@Sparks29032
Copy link
Collaborator Author

Sparks29032 commented Sep 3, 2025

Merging and reverting to run full stack of OS tests. Update: all pass, will not revert.

image

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.92%. Comparing base (9b44581) to head (97697f3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          23       23           
  Lines        1354     1355    +1     
=======================================
+ Hits         1353     1354    +1     
  Misses          1        1           
Files with missing lines Coverage Δ
tests/test_morphsqueeze.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sparks29032 Sparks29032 merged commit dce54cf into diffpy:main Sep 3, 2025
5 checks passed
@Sparks29032
Copy link
Collaborator Author

Changed the behavior to only give an error post-refinement. Previously, it was giving 100+ warnings in our tests, causing it to fail on macos-13.

Sparks29032 added a commit that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant