Skip to content

Conversation

@Sparks29032
Copy link
Collaborator

New tests from #249 and #250 give errors on Windows. Running as shell command (in the case of Windows) is not recommended.

We don't need to call the subprocess since we can directly simulate a CLI call similar to the tests already present in test_morphapp.py.

@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.92%. Comparing base (fc50526) to head (22f5ae3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          23       23           
  Lines        1354     1354           
=======================================
  Hits         1353     1353           
  Misses          1        1           
Files with missing lines Coverage Δ
tests/test_morphsqueeze.py 100.00% <100.00%> (ø)
tests/test_refine.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sparks29032
Copy link
Collaborator Author

Merging since this is the exact same set of tests, but without explicit subprocess calls. Refer to test_morphapp.py tests.

@Sparks29032 Sparks29032 merged commit 9b44581 into diffpy:main Sep 2, 2025
5 checks passed
@sbillinge
Copy link
Contributor

yes, this is much better. It is also possible to import the main function from the entry-point app and run that the desired inputs. This is how we would normally do it to be platform independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants