feat: increase fast cal to muD=7 #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 99.21% 99.20% -0.01%
==========================================
Files 5 5
Lines 254 253 -1
==========================================
- Hits 252 251 -1
Misses 2 2
🚀 New features to boost your workflow:
|
sbillinge
reviewed
Apr 15, 2025
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
please see comment. I suggested a different way to handle this.
| if mud > 7 or mud < 0.5: | ||
| raise ValueError( | ||
| f"mu*D is out of the acceptable range (0.5 to 6) " | ||
| f"Input mu*D = {mud} is out of the acceptable range " |
Contributor
There was a problem hiding this comment.
I still think this message is a bit harsh.
Is there a reason we don't just print a warning message and default to computing using the brute-force method?
Collaborator
Author
There was a problem hiding this comment.
Edited! Please check.
yucongalicechen
commented
Apr 16, 2025
|
|
||
| coeffs = np.array([f(mud) for f in INTERPOLATION_FUNCTIONS]) | ||
| muls = np.polyval(coeffs, MULS) | ||
| cve = 1 / muls |
Collaborator
Author
There was a problem hiding this comment.
Simplified the codes here.
sbillinge
approved these changes
Apr 18, 2025
|
|
||
| coeffs = np.array([f(mud) for f in INTERPOLATION_FUNCTIONS]) | ||
| muls = np.polyval(coeffs, MULS) | ||
| cve = 1 / muls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #167