test: copy_examples test
#65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbillinge ready for review |
|
Looks good as long as all the edits were brought over correctly! |
|
@sbillinge compared them side-by-side and the two PRs are the same |
|
Let's then implement the method |
|
@sbillinge ready for review. All tests pass except one that captures the bad output. Im still figuring out how to capture the statement, but wanted to make a push so you can leave comments on function styling and such |
cadenmyers13
commented
Oct 23, 2025
| self, | ||
| examples_to_copy: List[str], | ||
| target_dir: Path = None, | ||
| force: bool = False, |
There was a problem hiding this comment.
Added new force input param
|
I've included a test for the forced overwrite copy of examples. |
|
this still seems to be failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaned up version of this PR: #60