Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

I got this license from here: https://www.diffpy.org/products/diffpycmi/license.html

I updated the columbia copyright year to 2025, but please make sure this is okay.

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.00%. Comparing base (d70d879) to head (dd94d99).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #28       +/-   ##
===========================================
- Coverage   75.67%   50.00%   -25.68%     
===========================================
  Files           3        2        -1     
  Lines          37       18       -19     
===========================================
- Hits           28        9       -19     
  Misses          9        9               
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cadenmyers13
Copy link
Contributor Author

I also deleted the placeholder code made by skpkg

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, we want to go with the BSD 3-clause here. Let's not go with some horrible legacy license. The original license looks fine so I will just close this PR

@sbillinge
Copy link
Contributor

closed as not needed

@sbillinge sbillinge closed this Aug 6, 2025
@cadenmyers13 cadenmyers13 deleted the correct-license branch October 28, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants