doc: add bulk Ni tutorial to docs #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmyers13
commented
Jul 30, 2025
| :widths: 2 6 2 2 | ||
| :header-rows: 1 | ||
| :class: wrap-text | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Please check this table
cadenmyers13
commented
Jul 30, 2025
| :widths: 2 6 2 2 | ||
| :header-rows: 1 | ||
| :class: wrap-text | ||
|
|
Contributor
Author
There was a problem hiding this comment.
And also check this one too!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 75.67% 75.67%
=======================================
Files 3 3
Lines 37 37
=======================================
Hits 28 28
Misses 9 9 🚀 New features to boost your workflow:
|
Contributor
Author
|
@sbillinge ready for review |
Contributor
|
This looks fantastic! Spot on. I caught a couple of little typos but honestly I htink it is easier to merge and do any cleaning on a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ss for what I added. I added the tables explaining the parameters that are refined when PDF fitting. Please double check these to make sure my descriptions are good and that everything is correct. I don't think I missed any params but let me know if i did. Knowing what these parameters are and mean is super important to PDF fitting and I think its where most newbies should begin. It would be great if we could reuse these table elsewhere, refine them (no pun intended), and/or point people to them as a source.
The code for this tutorial was from the pdfttp_data repo, I modified a few things and changed some comments to hopefully make things easier to digest. I also ran this code and there are no bugs as it produced the fit shown in the last ss.