Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Jul 28, 2025

closes #13

I added installation instructions, a link to the primer book, and a link to the data and worked examples repo https://github.com/Billingegroup/pdfttp_data. The installation instructions are for conda-forge.

Screenshot 2025-07-28 at 12 25 03 PM

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.67%. Comparing base (d215a47) to head (2c2e584).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files           3        3           
  Lines          37       37           
=======================================
  Hits           28       28           
  Misses          9        9           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cadenmyers13
Copy link
Contributor Author

I also added citation to the index.rst

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of comments

Installation
------------

To install ``diffpy.cmi``, create a new conda environment and install the package from the conda-forge channel.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do I need a new environment or I could install it in an existing one if I wanted? I think most people get that, and we use this wording a lot, but it does worry me a bit that it will send a message that this needs to be installed in its own environment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge Added wording saying you can create a new env or activate and existing env

@sbillinge sbillinge merged commit 9506a4e into diffpy:main Jul 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(@cadenmyers13) Write lightweight documentation pointing to the PDF primer book

2 participants