- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5
docs: update getting started page #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @sbillinge ready for review | 
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files           3        3           
  Lines          37       37           
=======================================
  Hits           28       28           
  Misses          9        9           🚀 New features to boost your workflow:
 | 
| I also added citation to the index.rst | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of comments
        
          
                doc/source/getting-started.rst
              
                Outdated
          
        
      | Installation | ||
| ------------ | ||
|  | ||
| To install ``diffpy.cmi``, create a new conda environment and install the package from the conda-forge channel. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do I need a new environment or I could install it in an existing one if I wanted? I think most people get that, and we use this wording a lot, but it does worry me a bit that it will send a message that this needs to be installed in its own environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbillinge Added wording saying you can create a new env or activate and existing env
closes #13
I added installation instructions, a link to the primer book, and a link to the data and worked examples repo https://github.com/Billingegroup/pdfttp_data. The installation instructions are for conda-forge.