[tautschnig]

An ASSUME false has no successors in the control-flow graph, so no instruction is control dependent on it. The full slicer therefore removed it unless it was the slicing criterion, which made the instructions that follow it reachable on paths that it blocked, resulting in spurious counterexamples. For example, each failing Java assertion is encoded as ASSERT false followed by ASSUME false, so that with --full-slice any later assertion was reported as failing with the values that violate the first one. Loops unwound by goto-instrument --unwind (without unwinding assertions) and function bodies generated with
--generate-function-body-options assume-false end paths the same way; in the latter case the slicer removed the call of the function.

Always retain ASSUME false instructions. Their control dependencies, and the calls of the function that contains them, are then retained as well. On jbmc/regression/jbmc-strings with --full-slice this fixes 6 tests and does not cause any new failures.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.03%. Comparing base (37a17ad) to head (da5bbe4).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #9470   +/-   ##
========================================
  Coverage    81.02%   81.03%           
========================================
  Files         1723     1723           
  Lines       191326   191327    +1     
  Branches        73       73           
========================================
+ Hits        155029   155039   +10     
+ Misses       36297    36288    -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.