-
Notifications
You must be signed in to change notification settings - Fork 277
Support C17, C23 standards with goto-cc #8673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tautschnig
merged 1 commit into
diffblue:develop
from
tautschnig:bugfixes/8617-attributes-c23
Jul 8, 2025
Merged
Support C17, C23 standards with goto-cc #8673
tautschnig
merged 1 commit into
diffblue:develop
from
tautschnig:bugfixes/8617-attributes-c23
Jul 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8230566
to
4ef6a5e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8673 +/- ##
========================================
Coverage 80.39% 80.39%
========================================
Files 1688 1688
Lines 207387 207399 +12
Branches 73 73
========================================
+ Hits 166728 166747 +19
+ Misses 40659 40652 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kroening
reviewed
Jul 5, 2025
kroening
approved these changes
Jul 5, 2025
4ef6a5e
to
c460510
Compare
peterschrammel
approved these changes
Jul 5, 2025
c460510
to
de9db3c
Compare
We previously added the necessary language features in the C front end, but failed to permit selection of these standards in goto-cc. Also, GCC >= 11, Clang >= 17, and Visual Studio >= 2022 support C23-style attributes irrespective of the configured language standard. So let's accept these in our C front end whenever operating in these modes. Fixes: diffblue#8671
de9db3c
to
fbb9502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously added the necessary language features in the C front end, but failed to permit selection of these standards in goto-cc.
Also, GCC >= 11 and Clang >= 17 support C23-style attributes irrespective of the configured language standard. So let's accept these in our C front end whenever operating in GCC/Clang mode.
Fixes: #8671