Skip to content

Conversation

@tautschnig
Copy link
Collaborator

  1. Add tests for both the C and Java front-end.
  2. Make sure we support both variants of the modulus operator on floating-point values in the back-ends: the SMT back-end only supported remainder (and only for FPA mode), the propositional back-end did not distinguish between fmod and IEEE remainder.
  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Sep 12, 2023
@tautschnig tautschnig force-pushed the cleanup/floatbv-mod-rem branch 2 times, most recently from 2c2733f to a7d2d63 Compare September 12, 2023 14:04
@tautschnig
Copy link
Collaborator Author

Asking for help from @martin-cs: the remaining issue is that we need an ability to round-to-integer (roundToIntegral in SMT2) in our back-ends.

1. Add tests for both the C and Java front-end.
2. Make sure we support both variants of the modulus operator on
floating-point values in the back-ends: the SMT back-end only supported
remainder (and only for FPA mode), the propositional back-end did not
distinguish between fmod and IEEE remainder.
@tautschnig tautschnig force-pushed the cleanup/floatbv-mod-rem branch from 49c66f4 to f007d82 Compare October 22, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws Bugs or features of importance to AWS CBMC users bugfix Kani Bugs or features of importance to Kani Rust Verifier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants