Rewrite #[derive(Associations)] in derives2
#1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrif
force-pushed
the
sg-rewrite-associations
branch
from
bc664d7 to
bf6d86d
Compare
|
Yeah, I'll get to those soon. :) |
This was a pretty straightforward rewrite. Overall I feel much better about this code structure than what we had before. We're having to do a bit of funkyness to avoid rust-lang/rust#47941, but other than that everything here was pretty straightforward. I had the UI tests guide me the entire time.
sgrif
force-pushed
the
sg-rewrite-associations
branch
from
bf6d86d to
5669551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a pretty straightforward rewrite. Overall I feel much better
about this code structure than what we had before. We're having to do a
bit of funkyness to avoid
rust-lang/rust#47941, but other than that
everything here was pretty straightforward. I had the UI tests guide me
the entire time.