Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IF operator behave lazily (like AND and OR) #118

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

juannorris
Copy link
Contributor

@juannorris juannorris commented Mar 25, 2025

Fixes #115.

Benchmark Results

Comparing this change against v3.8.0.

I'm submitting multiple screenshots because the average time reported is (as expected) not consistent throughout executions, but results are good.

Screenshot 2025-03-25 at 3 13 31 PM

Screenshot 2025-03-25 at 3 22 37 PM

Screenshot 2025-03-25 at 3 45 23 PM

Screenshot 2025-03-25 at 2 38 01 PM

Screenshot 2025-03-25 at 3 49 59 PM

@juannorris juannorris changed the title Make IF operator evaluate clauses lazily Make IF operator behave lazily (like AND and OR) Mar 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.10%. Comparing base (fd7c2ae) to head (c723e3c).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
logic.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   92.79%   90.10%   -2.69%     
==========================================
  Files          12        9       -3     
  Lines        1041      910     -131     
==========================================
- Hits          966      820     -146     
- Misses         53       60       +7     
- Partials       22       30       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diegoholiveira diegoholiveira merged commit 6b88443 into diegoholiveira:main Mar 25, 2025
7 checks passed
@juannorris juannorris deleted the fix/make-if-lazy branch March 25, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"if" operator evaluates all conditions upfront
4 participants