Expose userCountryCode and userRegionCode - #163
Open
nicolas-chaix-didomi wants to merge 5 commits into
Open
nicolas-chaix-didomi wants to merge 5 commits into
nicolas-chaix-didomi wants to merge 5 commits into
Conversation
Add read-only access to the country and region the Didomi SDK determined for the current user, mirroring the existing countryCode and regionCode init parameters (CMP-6851).
Verified passing on Android (Pixel 6a) and iOS (simulator).
Regenerated by pod install after adding the didomi_sdk pod dependency needed to test on iOS.
nicolas-chaix-didomi
changed the title
regionCode is only populated for countries where a region concept applies (e.g. US states), so it can be null depending on the location the SDK resolves for the CI environment. CI failed with 'regionCode != null': is not true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userCountryCode/userRegionCodegetters mirroring the existing write-onlycountryCode/regionCodeinit parameters, wired through Dart, Android (Kotlin), and iOS (Swift) bridge layers.applicableRegulationgetter pattern (method channel +DidomiNotReadyException/isReady()guard).Test plan
flutter analyze— no issuesexample/integration_test/user_country_region_test.dart) passing on Android (physical Pixel 6a)