-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 兼容不设置高度时,窗口变化后更新画布尺寸 #1900
base: master
Are you sure you want to change the base?
Conversation
|
你好,这个功能都做了什么测试呢?是怎么测试的 |
那个 issue 的 codesandbox 我没打开。我现在的理解,如果 resize 未生效,先确认 resize 后,graphModel 中的 width/height 是否变成了预期的值。1. 如果值变了,容器样式没有变,那根据 width、height 值更新容器样式即可;2. 如果值没有变,先定位问题(为什么没变),再按 1 的逻辑处理。 |
@boyongjiong 我目前想到的能够兼容不配置宽或者高度时重新resize及配置时不清空resize,加入了两个属性记录。 |
刚刚review发现, |
解决resize传递宽高后渲染无效,并兼容窗口变化事件。