feat: use PeriodDimension in ThematicDialog #3407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3407.maps.netlify.dhis2.org |
2 tasks
| @@ -10,6 +10,10 @@ | |||
| height: 36px; | |||
| } | |||
|
|
|||
| .radioGroup.compact fieldset>div>div>label { | |||
There was a problem hiding this comment.
Is it possible to use the same spacing as is on line 25?
| /> | ||
| )} | ||
| {periodError && ( | ||
| <div key="error" className={styles.error}> |
There was a problem hiding this comment.
What is the purpose of the key attribute?
| display: flex; | ||
| align-items: center; | ||
| line-height: 1; | ||
| gap: 8px; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement: DHIS2-15796
Linked @dhis2/analytics PR: dhis2/analytics#1735
Overview
Main changes are:
PeriodDimensionperiod selector (transfer-style) for preset periods (in thematic dialog)StartEndDatefor start-end dates periods (in thematic, events and tracked entity dialogs)RenderingStrategythat controls the use of single map / timeline / split-map (in thematic dialog)SegmentedControlto switch between preset periods and start-end dates (in thematic dialog)Timelinecomponent to support multiple periods and from class to functional component (for thematic layers)Also improved keyboard navigation is introduced. The original object was to only to enable typing dates properly. In the end a number of files are modified to introduce consistency. Reviewing them should be quick so it might be a good idea to start here. A few other quality of life improvements included as well. All these changes are listed at the end.
1. Multiple periods selection
2.
PeriodDimensionThe new period selector used is
PeriodDimension(transfer-style) is defined in@dhis2/analytics.3.
StartEndDateWe updated and rename
StartEndDatestoStartEndDateto align with the Linelisting app but with an updated date pickerCalendarInputfrom@dhis2/uiwhich supports multiple calendars.EventDialogandTrackedEntityDialogare also updated to useStartEndDate.4.
RenderingStrategyWe updated the logic to account for multiple periods selection.
5.
SegmentedControl6.
TimelineSmaller quality of life improvements are included:
Keyboard navigation
Added "x" close modal buttons:
Small bug fixes
Checklist: