ci(deps): update google-java-format #18933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teleivo
force-pushed
the
update-formatter
branch
from
464737f to
7656cb3
Compare
david-mackessy
approved these changes
Oct 31, 2024
enricocolasante
approved these changes
Oct 31, 2024
jbee
approved these changes
Oct 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/google/google-java-format/releases
google-java-formatwas set to the default version of https://github.com/google/google-java-format/releases/tag/google-java-format-1.8 from May 2020.https://github.com/diffplug/spotless/tree/main/plugin-maven#google-java-format
They do fix bugs and add support for new language features. They also stop supporting running on old JDKs at some point
https://github.com/google/google-java-format/releases
So I don't think we can never update it and have to accept some formatting changes once in a while.
It looks like text block formatting is still under debate
google/google-java-format#1087 (comment)