feat: view mode dashboards-bar design changes [DHIS2-18441] #3155
Conversation
|
🚀 Deployed on https://pr-3155.dashboard.netlify.dhis2.org |
…t re-mounts due to react-router
HendrikThePendric
changed the title
…ashboard-app into feat/header-bar-design-ui-update
|
| @@ -47,6 +47,10 @@ const CategorizedMenuGroup = ({ | |||
| onChangeItemsLimit(type) | |||
| } | |||
|
|
|||
| const showHideMoreLabel = seeMore | |||
There was a problem hiding this comment.
showFewerMoreLabel is a more accurate name
| }, [url]) | ||
|
|
||
| return ( | ||
| <span |
There was a problem hiding this comment.
Was this change to get rid of the invalid html warning?
| const getFilterValuesText = (values) => | ||
| values.length === 1 | ||
| ? values[0].name | ||
| : i18n.t('{{count}} selected', { count: values.length }) |
There was a problem hiding this comment.
I wonder if we should handle plurals here, even though singular and plural are the same in this case in English. Might it be different in other languages?
| @@ -10,6 +10,10 @@ export const acSetDashboardsFilter = (value) => ({ | |||
| value, | |||
| }) | |||
|
|
|||
| /* TODO: Possibly this action can be removed if we keep a an input | |||
There was a problem hiding this comment.
Can we go ahead with this?
Implements DHIS2-18441 according to design doc
Key features
Description
Implements the new design according to the design doc
TODO
Known issues
@dhis2/uiwhich comes with some accessibility improvements including arrow-key keyboard navigation for menus. The navigation- and more-actions-menu in the new dashboards-bar are using these. But the filter-menu is using a custom menu-list and this can be used by keyboard by using the tab-key. This inconsistency will be tackled in a separate PR, see DHIS2-18537.Screenshots