feat: add title and subtitle to data sets if set in display options #407
Conversation
|
🚀 Deployed on https://pr-407--dhis2-data-entry.netlify.app |
| .sectionTab { | ||
| margin-bottom: 8px; | ||
| } | ||
| .textLeft{ | ||
| text-align: left; |
There was a problem hiding this comment.
suggest text-align: inset-inline-start to be RTL-friendly
| text-align: center; | ||
| } | ||
| .textRight{ | ||
| text-align: right; |
There was a problem hiding this comment.
suggest text-align: inset-inline-end to be RTL-friendly
| margin: 2px; | ||
| font-size: 1.5em; | ||
| } | ||
| .sectionsCustomerText{ |
| [styles.textLeft]: | ||
| displayOptions.customText?.align === 'left', | ||
| [styles.textCenter]: | ||
| displayOptions.customText?.align === 'center', |
There was a problem hiding this comment.
styles.textCenter be the default if displayOptions.customText?.align is undefined? It seems like that is the default option in the maintenance app through the UI, so I don't know if you want to set it to be the default in the data entry app as well (could occur if someone edits the display options outside of the UI)
| className={styles.sectionDescription} | ||
| dangerouslySetInnerHTML={{ __html: html }} | ||
| ></div> | ||
| <p className={className} dangerouslySetInnerHTML={{ __html: html }}></p> |
There was a problem hiding this comment.
is it intentional to change to
element? It seems that will insert an extra blank line that we didn't have before?
There was a problem hiding this comment.
yep this one is intentional :)
flaminic
force-pushed
the
DHIS2-18129/add-custom-text-to-data-sets
branch
from
fce6ee5 to
5d1f679
Compare
…ght to line start / line end
flaminic
force-pushed
the
DHIS2-18129/add-custom-text-to-data-sets
branch
from
5d1f679 to
ed91642
Compare
fix: custom text styles
|
🎉 This PR is included in version 100.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implements DHIS2-18129.
This PR allows users to add a title/ substitle to datasets
Implementation details
The displayOptions was added as a JSON type in the BE to allow us flexibility to add more options without updating the back-end. See discussion in dhis2/dhis2-core#16562
Background
We are aiming to add more form configuration options as part of an initiative to provide configurations natively to data entry forms to reduce the necessity for custom forms. Users are currently building custom forms as a workaround for shortcomings of the configuration options (ability to transpose, or customise a cell design) or implementation (such to avoid issues with RTL issues).
This is an RFC that describes the approach and the priorities for form configuration options. This is based on a thorough investigation by the functional design team for custom form use cases in real-life implementations. Based on that investigation, the ability to add custom text to sections were one of the main reasons people choose to go the custom forms route so we're tackling these first.
Preview